Added Default to bootstrap cmd
#2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardLitt
force-pushed
the
feature/add-default-to-bootstrap
branch
from
afe1063
to
4267f01
Compare
RichardLitt
added
topic/docs-ipfs
|
I don't think the changed logic there is correct... I beleive it was correct before |
| @@ -160,10 +160,9 @@ var bootstrapRemoveCmd = &cmds.Command{ | |||
| } | |||
|
|
|||
| var removed []config.BootstrapPeer | |||
| removed, err = bootstrapRemove(r, cfg, input) | |||
Part of #2484. License: MIT Signed-off-by: Richard Littauer <[email protected]>
RichardLitt
force-pushed
the
feature/add-default-to-bootstrap
branch
from
4267f01
to
bffd648
Compare
|
This is why we code review. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2484.